Skip to content

Conversation

@thassiov
Copy link
Contributor

@thassiov thassiov commented Jan 6, 2021

Proposed changes (including videos or screenshots)

The user managing apps can see which permissions the app requires before being installed in the instance and decide whether to install it. Works for both marketplace and manual installations.
2021-01-21-183254_1091x316_scrot
2021-01-21-183426_1086x369_scrot

Issue(s)

Steps to test or reproduce

Further comments

@lgtm-com
Copy link

lgtm-com bot commented Jan 6, 2021

This pull request introduces 2 alerts when merging b40e8ad into 5769cec - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jan 18, 2021

This pull request introduces 1 alert when merging d08cf6e into 5027bf5 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jan 20, 2021

This pull request introduces 1 alert when merging c91c8ed into b55a5ea - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@thassiov thassiov changed the title [WIP] Apps Permission System frontend [NEW][APPS] Apps Permission System frontend Jan 21, 2021
@thassiov thassiov marked this pull request as ready for review January 21, 2021 21:20
@thassiov thassiov requested a review from d-gubert January 21, 2021 21:20
@lgtm-com
Copy link

lgtm-com bot commented Jan 22, 2021

This pull request introduces 1 alert when merging d31b2ae into 9ff1e16 - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

@lgtm-com
Copy link

lgtm-com bot commented Jan 22, 2021

This pull request introduces 1 alert when merging 608652e into 9ff1e16 - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

@d-gubert d-gubert changed the title [NEW][APPS] Apps Permission System frontend [NEW][Apps] Apps Permission System Jan 22, 2021
@thassiov thassiov force-pushed the feat/apps-permissions branch from 2a110ac to a90156d Compare January 23, 2021 00:09
@thassiov thassiov merged commit e15a88e into develop Jan 23, 2021
@thassiov thassiov deleted the feat/apps-permissions branch January 23, 2021 00:46
@sampaiodiego sampaiodiego mentioned this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants